Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SerdeAny issue on libaf-fuzz #2715

Closed

Conversation

R9295
Copy link
Collaborator

@R9295 R9295 commented Nov 21, 2024

test

@R9295
Copy link
Collaborator Author

R9295 commented Nov 21, 2024

lol why is cargo-fuzz failing?

@tokatoka
Copy link
Member

they have the same problem. cargo-fuzz builds slow libafl-fuzz builds faster. fixing libafl-fuzz made cargo-fuzz problem appear

@R9295
Copy link
Collaborator Author

R9295 commented Nov 21, 2024

ah thanks - will fix that

@R9295
Copy link
Collaborator Author

R9295 commented Nov 21, 2024

I think this is an issue with the new ctor

@domenukk
Copy link
Member

Coypied from a chat:

So I think what's wrong is that impl_serdeany! uses #[cfg(any(not(feature = "serdeany_autoreg"), miri))] and serdeany_autoreg is not a feature flag of the current Cargo.toml

That means we have a bug in our macro basically

We want it to self-register if serdeany_autoreg is set for LibAFL

It's odd it works/worked at all?

@addisoncrump
Copy link
Collaborator

Superceded by #2721.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants